-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/data): update query service and commands #1156
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1156 +/- ##
==========================================
- Coverage 69.59% 69.45% -0.14%
==========================================
Files 221 227 +6
Lines 23082 23283 +201
==========================================
+ Hits 16064 16172 +108
- Misses 5638 5712 +74
- Partials 1380 1399 +19
Flags with carried forward coverage won't be shown. Click here to find out more. |
Ready for review again. I can walk through the changes and break out into small pull requests if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-approving. just needs iterator closes & paginations mentioned above 👍🏻
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Description
Ref: #714 / #1152
This pull request makes the following changes:
ByIRI
andByHash
toAnchorByIRI
andAnchorByHash
for clarificationAttestorsByIRI
andAttestorsByHash
toAttestationsByIRI
andAttestationsByHash
for clarificationContentEntry
toAnchorInfo
and moves toquery.go
for consistent query response type namingAttestorEntry
toAttestationInfo
and moves toquery.go
for consistent query response type namingQuery
prefix for clarification (we are not querying state)post
option forConvertHashToIRI
ByHash
to includepost
option providing previously excluded gRPC REST endpointsIf need be, I can break this up into smaller pull requests but one thing led to another...
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change