Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/ecocredit): fix create batch issuance with same recipient #1144

Merged
merged 8 commits into from
Jun 3, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Jun 1, 2022

Description

Closes: #1139

Fixes create batch to account for issuance with same recipient.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo changed the title fix(x/ecocredit): fix create batch supply and balance updates fix(x/ecocredit): fix create batch when issuance with same recipient Jun 1, 2022
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1144 (723afc8) into master (530130f) will increase coverage by 0.01%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #1144      +/-   ##
==========================================
+ Coverage   69.27%   69.28%   +0.01%     
==========================================
  Files         220      220              
  Lines       22786    22801      +15     
==========================================
+ Hits        15784    15797      +13     
- Misses       5624     5626       +2     
  Partials     1378     1378              
Flag Coverage Δ
experimental-codecov 69.35% <77.77%> (+0.01%) ⬆️
stable-codecov 63.63% <77.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo changed the title fix(x/ecocredit): fix create batch when issuance with same recipient fix(x/ecocredit): fix create batch issuance with same recipient Jun 1, 2022
@ryanchristo ryanchristo marked this pull request as ready for review June 1, 2022 22:38
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just one spot we can use a util function 👍🏻

x/ecocredit/server/core/create_batch.go Outdated Show resolved Hide resolved
Copy link
Member

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch -- should we also check again that BatchMint doesn't override balances?

-- edit: Just checked, seems like we handle things correctly in BatchMint :)

@ryanchristo ryanchristo merged commit faeb38a into master Jun 3, 2022
@ryanchristo ryanchristo deleted the ryan/1139-fix-create-batch branch June 3, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch balance primary key already exists when creating a credit batch
4 participants