Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecocredit): add projects by admin query #1141

Merged
merged 6 commits into from
Jun 3, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Jun 1, 2022

Description

Closes: #1137


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1141 (49bb93d) into master (1abcee8) will decrease coverage by 0.02%.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##           master    #1141      +/-   ##
==========================================
- Coverage   63.67%   63.65%   -0.03%     
==========================================
  Files         216      217       +1     
  Lines       20849    20900      +51     
==========================================
+ Hits        13276    13303      +27     
- Misses       6265     6279      +14     
- Partials     1308     1318      +10     
Flag Coverage Δ
stable-codecov 63.65% <52.94%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 marked this pull request as ready for review June 1, 2022 13:47
Comment on lines 508 to 510
Examples:
$%s query %s projects-by-admin regenx1v44...
$%s q %s projects-by-admin regenx1v44.. --limit 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use Example for examples.

Documentation generated using Example:

Documentation with examples in the Long description:

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

rpc ProjectsByAdmin(QueryProjectsByAdminRequest)
returns (QueryProjectsByAdminResponse) {
option (google.api.http).get =
"/regen/ecocredit/v1/projects/by-admin/{admin}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong preference but it looks like we have a couple formats for REST endpoints being used. Let's merge this as is and update REST endpoints throughout either using this format or another.

Opened #1152

@ryanchristo ryanchristo merged commit 530130f into master Jun 3, 2022
@ryanchristo ryanchristo deleted the aleem/1137-projects-by-admin branch June 3, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add queries for all projects and projects by admin
4 participants