-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecocredit): add projects by admin query #1141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1141 +/- ##
==========================================
- Coverage 63.67% 63.65% -0.03%
==========================================
Files 216 217 +1
Lines 20849 20900 +51
==========================================
+ Hits 13276 13303 +27
- Misses 6265 6279 +14
- Partials 1308 1318 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
x/ecocredit/client/query.go
Outdated
Examples: | ||
$%s query %s projects-by-admin regenx1v44... | ||
$%s q %s projects-by-admin regenx1v44.. --limit 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use Example
for examples.
Documentation generated using Example
:
Documentation with examples in the Long
description:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
rpc ProjectsByAdmin(QueryProjectsByAdminRequest) | ||
returns (QueryProjectsByAdminResponse) { | ||
option (google.api.http).get = | ||
"/regen/ecocredit/v1/projects/by-admin/{admin}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong preference but it looks like we have a couple formats for REST endpoints being used. Let's merge this as is and update REST endpoints throughout either using this format or another.
Opened #1152
Description
Closes: #1137
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change