Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/ecocredit): deprecate basket exponent and use precision #1135

Merged
merged 6 commits into from
Jun 1, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented May 28, 2022

Description

Closes: #1133

This pull request deprecates basket exponent and uses credit type precision as exponent for converting credits to basket tokens and for determining the SI prefix used in basket denom.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #1135 (315e1f5) into master (12969b5) will increase coverage by 5.71%.
The diff coverage is 77.27%.

@@            Coverage Diff             @@
##           master    #1135      +/-   ##
==========================================
+ Coverage   64.12%   69.83%   +5.71%     
==========================================
  Files         215      218       +3     
  Lines       20357    22240    +1883     
==========================================
+ Hits        13053    15531    +2478     
+ Misses       6043     5367     -676     
- Partials     1261     1342      +81     
Flag Coverage Δ
experimental-codecov 69.68% <77.27%> (?)
stable-codecov 64.15% <77.27%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo marked this pull request as ready for review May 29, 2022 03:32
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo mentioned this pull request May 31, 2022
19 tasks
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo merged commit e326959 into master Jun 1, 2022
@ryanchristo ryanchristo deleted the ryan/1133-basket-exponent branch June 1, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

basket Take() results in eventual max precision exceeded error if basket exponent > credit precision
3 participants