Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/data): query resolvers by url and return resolver info #1132

Merged
merged 6 commits into from
Jun 2, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented May 26, 2022

Description

Ref: #1111 / #1128

This pull request adds QueryResolversByUrl with pagination and updates resolver queries to return ResolverInfo.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1132 (4331f27) into master (d8119ce) will increase coverage by 0.18%.
The diff coverage is 93.39%.

@@            Coverage Diff             @@
##           master    #1132      +/-   ##
==========================================
+ Coverage   69.89%   70.07%   +0.18%     
==========================================
  Files         218      218              
  Lines       22230    22384     +154     
==========================================
+ Hits        15538    15686     +148     
+ Misses       5352     5347       -5     
- Partials     1340     1351      +11     
Flag Coverage Δ
experimental-codecov 69.95% <93.39%> (+0.15%) ⬆️
stable-codecov 64.43% <93.39%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo force-pushed the ryan/1111-resolvers-by-url branch from 053ba42 to 4fcccf8 Compare May 29, 2022 20:29
@ryanchristo ryanchristo force-pushed the ryan/1111-resolvers-by-url branch from 1c4a7f0 to 226ab68 Compare May 29, 2022 20:32
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo merged commit 22fcf03 into master Jun 2, 2022
@ryanchristo ryanchristo deleted the ryan/1111-resolvers-by-url branch June 2, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants