Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update make commands #1097

Merged
merged 9 commits into from
Jun 22, 2022
Merged

build: update make commands #1097

merged 9 commits into from
Jun 22, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented May 9, 2022

Description

Closes: #441

In the process of updating contributing guidelines (#1003) and attempting to add instructions on how to use make commands, I noticed a lot of broken and outdated make commands. This pull request trims down and refines make commands and updates build commands to align with those in other sdk applications including gaia, osmosis, and provenance.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1097 (c42b6b6) into master (5de1015) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
+ Coverage   70.08%   70.24%   +0.16%     
==========================================
  Files         235      234       -1     
  Lines       23811    23631     -180     
==========================================
- Hits        16687    16599      -88     
+ Misses       5688     5618      -70     
+ Partials     1436     1414      -22     
Flag Coverage Δ
experimental-codecov 70.25% <ø> (-0.17%) ⬇️
stable-codecov 64.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo mentioned this pull request May 10, 2022
19 tasks
@ryanchristo
Copy link
Member Author

Pending #1096

@ryanchristo ryanchristo marked this pull request as ready for review May 31, 2022 01:36
@ryanchristo ryanchristo requested a review from clevinson May 31, 2022 01:37
proto.mk Outdated Show resolved Hide resolved
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! tested install, build on intel x86 arch successfully 👍🏻

@ryanchristo ryanchristo merged commit d7c114c into master Jun 22, 2022
@ryanchristo ryanchristo deleted the ryan/update-make-commands branch June 22, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make install doesn't build 'regen'
3 participants