-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update make commands #1097
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1097 +/- ##
==========================================
+ Coverage 70.08% 70.24% +0.16%
==========================================
Files 235 234 -1
Lines 23811 23631 -180
==========================================
- Hits 16687 16599 -88
+ Misses 5688 5618 -70
+ Partials 1436 1414 -22
Flags with carried forward coverage won't be shown. Click here to find out more. |
Pending #1096 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT! tested install, build on intel x86 arch successfully 👍🏻
Description
Closes: #441
In the process of updating contributing guidelines (#1003) and attempting to add instructions on how to use make commands, I noticed a lot of broken and outdated make commands. This pull request trims down and refines make commands and updates build commands to align with those in other sdk applications including gaia, osmosis, and provenance.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change