Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ecocredit): add buy scenario to integration test #1079

Merged
merged 16 commits into from
May 19, 2022

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented May 3, 2022

Description

  • adds a buydirect scenario to the scenario test

Closes: n/a


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #1079 (26b2741) into master (334885c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
+ Coverage   68.25%   68.27%   +0.02%     
==========================================
  Files         212      211       -1     
  Lines       21255    21308      +53     
==========================================
+ Hits        14507    14548      +41     
- Misses       5422     5428       +6     
- Partials     1326     1332       +6     
Flag Coverage Δ
experimental-codecov 68.27% <100.00%> (+0.11%) ⬆️
stable-codecov ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@technicallyty technicallyty marked this pull request as ready for review May 3, 2022 16:13
@technicallyty technicallyty marked this pull request as draft May 5, 2022 18:47
@technicallyty technicallyty marked this pull request as ready for review May 11, 2022 16:31
x/ecocredit/server/testsuite/suite.go Outdated Show resolved Hide resolved
x/ecocredit/server/testsuite/suite.go Show resolved Hide resolved
x/ecocredit/server/testsuite/suite.go Outdated Show resolved Hide resolved
x/ecocredit/server/testsuite/suite.go Show resolved Hide resolved
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving.

@ryanchristo ryanchristo enabled auto-merge (squash) May 19, 2022 17:11
@ryanchristo ryanchristo merged commit 7c1fb1d into master May 19, 2022
@ryanchristo ryanchristo deleted the ty/buy_integration_test branch May 19, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants