Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix ecocredit test and disable orm test #1070

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Apr 29, 2022

Description

Closes: #1068

This pull request fixes TestSellOrders and disables TestPrimaryKeyTable, both of which were causing intermittent errors, and the second being part of the orm module, which is no longer maintained and will soon be deleted.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo enabled auto-merge (squash) April 29, 2022 02:32
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1070 (80e26e4) into master (7d75fe3) will increase coverage by 5.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1070      +/-   ##
==========================================
+ Coverage   62.93%   68.58%   +5.65%     
==========================================
  Files         220      224       +4     
  Lines       19526    21670    +2144     
==========================================
+ Hits        12288    14863    +2575     
+ Misses       5983     5474     -509     
- Partials     1255     1333      +78     
Flag Coverage Δ
experimental-codecov 68.46% <ø> (?)
stable-codecov 62.61% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo merged commit 157181f into master Apr 29, 2022
@ryanchristo ryanchristo deleted the ryan/1068-intermittent-tests branch April 29, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent code coverage errors
3 participants