Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ecocredit): delete v1alpha2 types #1063

Merged
merged 8 commits into from
May 2, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Apr 27, 2022

Description

Closes: #898

  • removed v1alpha2 proto and implementation
  • removed unused files & functions

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aleem1314 aleem1314 marked this pull request as ready for review April 28, 2022 08:17
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #1063 (cf39b33) into master (4ecc793) will decrease coverage by 5.67%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
- Coverage   68.59%   62.92%   -5.68%     
==========================================
  Files         224      215       -9     
  Lines       21681    19390    -2291     
==========================================
- Hits        14873    12201    -2672     
- Misses       5467     5926     +459     
+ Partials     1341     1263      -78     
Flag Coverage Δ
experimental-codecov ?
stable-codecov 62.92% <80.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We should delete the v1alpha2 directory though. This version was never used in production and therefore is no longer needed. Pre-approving.

proto/regen/ecocredit/v1alpha2/events.proto Show resolved Hide resolved
@aleem1314 aleem1314 requested a review from technicallyty May 2, 2022 09:11
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo enabled auto-merge (squash) May 2, 2022 17:26
@ryanchristo ryanchristo merged commit 064955a into master May 2, 2022
@ryanchristo ryanchristo deleted the aleem/ecocredit-v1alpha1-cleanup branch May 2, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wire up new submodules to ecocredit module
3 participants