Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecocredit/core): SealBatch server impl #1060

Merged
merged 11 commits into from
May 2, 2022
Merged

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Apr 26, 2022

Description

  • implements the SealBatch server method
  • adds seal event

ref: #973


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1060 (429d1f2) into master (429d1f2) will not change coverage.
The diff coverage is n/a.

❗ Current head 429d1f2 differs from pull request most recent head d351eb0. Consider uploading reports for the commit d351eb0 to get more accurate results

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   68.98%   68.98%           
=======================================
  Files         218      218           
  Lines       21335    21335           
=======================================
  Hits        14717    14717           
  Misses       5268     5268           
  Partials     1350     1350           
Flag Coverage Δ
experimental-codecov 68.79% <0.00%> (ø)
stable-codecov 62.93% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a couple comments.

x/ecocredit/server/core/seal_batch.go Outdated Show resolved Hide resolved
x/ecocredit/server/core/seal_batch.go Outdated Show resolved Hide resolved
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo
Copy link
Member

@technicallyty can you fix conflicts? 🙏

@ryanchristo ryanchristo enabled auto-merge (squash) May 2, 2022 21:04
@ryanchristo ryanchristo merged commit c160e04 into master May 2, 2022
@ryanchristo ryanchristo deleted the ty/973-seal_batch_impl branch May 2, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants