-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecocredit/core): dynamic batch minting #1059
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
- Coverage 69.00% 62.82% -6.19%
==========================================
Files 218 215 -3
Lines 21276 19449 -1827
==========================================
- Hits 14682 12219 -2463
- Misses 5267 5953 +686
+ Partials 1327 1277 -50
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. A few questions and some minor suggestions.
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
…rk/regen-ledger into ty/973-dynamic_batch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@technicallyty looks like the merge caused duplicate imports. Can you fix? 🙏 |
Description
Not Found
cases.ref: #973
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change