Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/ecocredit): readable marketplace query responses #1054

Merged
merged 5 commits into from
Apr 27, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Apr 25, 2022

Description

Closes: #1028

Add SellOrderInfo with human-readable fields (including ask_denom) and update query implementation.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1054 (ef95b7b) into master (e4e9a15) will increase coverage by 0.14%.
The diff coverage is 89.55%.

@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
+ Coverage   68.77%   68.91%   +0.14%     
==========================================
  Files         222      223       +1     
  Lines       21338    21412      +74     
==========================================
+ Hits        14676    14757      +81     
+ Misses       5340     5336       -4     
+ Partials     1322     1319       -3     
Flag Coverage Δ
experimental-codecov 68.82% <89.55%> (+0.04%) ⬆️
stable-codecov 62.87% <89.55%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo marked this pull request as ready for review April 26, 2022 18:53
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo merged commit ee54c46 into master Apr 27, 2022
@ryanchristo ryanchristo deleted the ryan/1028-marketplace-queries branch April 27, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SellOrder queries don't provide sufficient AskPrice information
3 participants