-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/ecocredit): update project id and batch denom #1046
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1046 +/- ##
==========================================
- Coverage 68.97% 62.93% -6.05%
==========================================
Files 216 213 -3
Lines 21312 19385 -1927
==========================================
- Hits 14701 12200 -2501
- Misses 5259 5908 +649
+ Partials 1352 1277 -75
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - just one nit. i'm not partial to whether or not we do project ID's so ill approve once theres product consensus 👍🏻
Concept ACK on removing custom |
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pre-approving
@aleem1314 can you review when you get a chance? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre approving
Description
Closes: #1032
Update project id to include class id and batch denom to use project id rather than class id. This pull request also removes support for custom project ids but I can revert if we feel this is something we still want to support.
This pull request does not include the following items brought up in #1032 that are still being discussed in #883 and #1066:
class-project-id
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change