Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ecocredit): update BatchInfo.BatchDenom to BatchInfo.Denom #1039

Merged
merged 4 commits into from
Apr 21, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Apr 20, 2022

Description

Closes: #1031


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. TestInitExportGenesis is failing CI checks, so it looks like some cases of batch_denom are still being used in the genesis code.

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #1039 (268d06c) into master (9aa86c4) will decrease coverage by 10.89%.
The diff coverage is 64.28%.

❗ Current head 268d06c differs from pull request most recent head 16b2f6c. Consider uploading reports for the commit 16b2f6c to get more accurate results

@@             Coverage Diff             @@
##           master    #1039       +/-   ##
===========================================
- Coverage   59.83%   48.93%   -10.90%     
===========================================
  Files         226      225        -1     
  Lines       22765    23442      +677     
===========================================
- Hits        13622    11472     -2150     
- Misses       7823    10726     +2903     
+ Partials     1320     1244       -76     
Flag Coverage Δ
experimental-codecov 48.80% <64.28%> (-10.93%) ⬇️
stable-codecov 41.71% <64.28%> (-11.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@technicallyty technicallyty enabled auto-merge (squash) April 21, 2022 17:41
@technicallyty technicallyty disabled auto-merge April 21, 2022 18:11
@technicallyty
Copy link
Contributor

looks like merge from master broke some things, @aleem1314

@ryanchristo ryanchristo merged commit 44a3276 into master Apr 21, 2022
@ryanchristo ryanchristo deleted the aleem/1031-batch-denom branch April 21, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update batch_denom to denom within BatchInfo
4 participants