-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ecocredit): migrate core invariants to use v1 types #1017
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
==========================================
- Coverage 59.89% 59.75% -0.14%
==========================================
Files 224 226 +2
Lines 22776 22765 -11
==========================================
- Hits 13641 13603 -38
- Misses 7813 7850 +37
+ Partials 1322 1312 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. A few comments and suggestions.
…into aleem/ecocredit-core-invarinats
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
…regen-network/regen-ledger into aleem/ecocredit-core-invarinats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, a few suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Variable names using id
should be using key
. Pre-approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! 👍🏻
Description
Closes: #982
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change