Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ecocredit): migrate core invariants to use v1 types #1017

Merged
merged 16 commits into from
Apr 21, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Apr 13, 2022

Description

Closes: #982


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aleem1314 aleem1314 marked this pull request as ready for review April 14, 2022 15:08
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1017 (bf625cb) into master (5bd2f48) will decrease coverage by 0.13%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
- Coverage   59.89%   59.75%   -0.14%     
==========================================
  Files         224      226       +2     
  Lines       22776    22765      -11     
==========================================
- Hits        13641    13603      -38     
- Misses       7813     7850      +37     
+ Partials     1322     1312      -10     
Flag Coverage Δ
experimental-codecov 59.63% <61.53%> (-0.17%) ⬇️
stable-codecov 53.25% <61.53%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

x/ecocredit/server/basket/util.go Outdated Show resolved Hide resolved
x/ecocredit/server/basket/util.go Outdated Show resolved Hide resolved
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A few comments and suggestions.

x/ecocredit/server/basket/util_test.go Show resolved Hide resolved
x/ecocredit/server/basket/util_test.go Show resolved Hide resolved
x/ecocredit/server/core/invariants.go Outdated Show resolved Hide resolved
x/ecocredit/server/invariants_test.go Outdated Show resolved Hide resolved
x/ecocredit/server/invariants_test.go Outdated Show resolved Hide resolved
x/ecocredit/server/invariants_test.go Outdated Show resolved Hide resolved
@aleem1314 aleem1314 requested a review from ryanchristo April 20, 2022 14:38
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, a few suggestions

x/ecocredit/server/basket/util.go Outdated Show resolved Hide resolved
x/ecocredit/server/core/invariants.go Outdated Show resolved Hide resolved
x/ecocredit/server/core/invariants.go Outdated Show resolved Hide resolved
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Variable names using id should be using key. Pre-approving.

@aleem1314 aleem1314 requested a review from technicallyty April 21, 2022 14:04
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 👍🏻

@ryanchristo ryanchristo merged commit 9aa86c4 into master Apr 21, 2022
@ryanchristo ryanchristo deleted the aleem/ecocredit-core-invarinats branch April 21, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update ecocredit invariants to use v1 (currently v1alpha2)
3 participants