Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/data): consistent use of content hash #1014

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Apr 12, 2022

Description

Closes: #1006

This pull request applies consistent use of content_hash and content_hashes in the data module.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo marked this pull request as ready for review April 12, 2022 23:58
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -15,8 +15,8 @@ message GenesisState {

// GenesisContentEntry is a genesis content entry
message GenesisContentEntry {
// hash is the ContentHash
ContentHash hash = 1;
// content_hash is the ContentHash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can delete this file. We are not using genesis types.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1014 (c1e6ae9) into master (470f881) will decrease coverage by 0.11%.
The diff coverage is 83.60%.

@@            Coverage Diff             @@
##           master    #1014      +/-   ##
==========================================
- Coverage   60.09%   59.98%   -0.12%     
==========================================
  Files         217      216       -1     
  Lines       23212    23186      -26     
==========================================
- Hits        13950    13908      -42     
- Misses       7973     7992      +19     
+ Partials     1289     1286       -3     
Flag Coverage Δ
experimental-codecov 59.98% <83.60%> (-0.02%) ⬇️
stable-codecov ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo merged commit 52061e8 into master Apr 13, 2022
@ryanchristo ryanchristo deleted the ryan/1006-data-content-hash branch April 13, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent reference to content hash in data module
3 participants