-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/data): consistent use of content hash #1014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
proto/regen/data/v1/genesis.proto
Outdated
@@ -15,8 +15,8 @@ message GenesisState { | |||
|
|||
// GenesisContentEntry is a genesis content entry | |||
message GenesisContentEntry { | |||
// hash is the ContentHash | |||
ContentHash hash = 1; | |||
// content_hash is the ContentHash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can delete this file. We are not using genesis types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #1014 +/- ##
==========================================
- Coverage 60.09% 59.98% -0.12%
==========================================
Files 217 216 -1
Lines 23212 23186 -26
==========================================
- Hits 13950 13908 -42
- Misses 7973 7992 +19
+ Partials 1289 1286 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
Closes: #1006
This pull request applies consistent use of
content_hash
andcontent_hashes
in the data module.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change