Test against multiple versions of monero (monero-rs#75)

* chore: split CI into 3 files * style: format * ci: run multiple monero versions * test: verify a range of compatible versions * fix: don't check for specific versions
refring · Aug 2, 2022 · f202619 · f202619
1 parent 64d53cf
commit f202619
Show file tree

Hide file tree

Showing 9 changed files with 131 additions and 93 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -0,0 +1,40 @@
+on: [push, pull_request]
+
+name: Build
+
+jobs:
+  check:
+    strategy:
+      matrix:
+        rust: [
+          1.56.1,
+          stable,
+      ]
+    name: Check
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: ${{ matrix.rust }}
+          override: true
+      - uses: actions-rs/cargo@v1
+        with:
+          command: check
+
+  clippy:
+    name: Clippy
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          override: true
+      - run: rustup component add clippy
+      - uses: actions-rs/cargo@v1
+        with:
+          command: clippy
+          args: -- -D warnings
diff --git a/.github/workflows/format.yml b/.github/workflows/format.yml
@@ -0,0 +1,32 @@
+on: [push, pull_request]
+
+name: Format
+
+jobs:
+  fmt:
+    name: Rust format
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          override: true
+      - run: rustup component add rustfmt
+      - uses: actions-rs/cargo@v1
+        with:
+          command: fmt
+          args: --all -- --check
+
+  mdtomlfmt:
+    name: Generic format (md,toml)
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v3
+
+    - name: Run dprint
+      run: |
+        curl -fsSL https://dprint.dev/install.sh | sh
+        /home/runner/.dprint/bin/dprint check
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -0,0 +1,49 @@
+on: [push, pull_request]
+
+name: Test
+
+jobs:
+  test:
+    name: Test
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        monero: [ 0.17.3.0, 0.17.3.2, 0.18.0.0 ]
+
+    services:
+      monerod:
+        image: ghcr.io/farcaster-project/containers/monerod:${{ matrix.monero }}
+        env:
+          NETWORK: regtest
+          MONEROD_RPC_PORT: 18081
+          MONEROD_ZMQ_PORT: 18082
+          OFFLINE: --offline
+          DIFFICULTY: 1
+        ports:
+        - 18081:18081
+        - 18082:18082
+      monero-wallet-rpc:
+        image: ghcr.io/farcaster-project/containers/monero-wallet-rpc:${{ matrix.monero }}
+        env:
+          MONERO_DAEMON_ADDRESS: monerod:18081
+          MONERO_DAEMON_HOST: monerod:18081
+          WALLET_RPC_PORT: 18083
+        ports:
+        - 18083:18083
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Install Rust Stable
+        uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          override: true
+
+      - name: Cargo test
+        uses: actions-rs/cargo@v1
+        with:
+          command: test
diff --git a/tests/clients_tests/basic_wallet.rs b/tests/clients_tests/basic_wallet.rs
@@ -24,7 +24,7 @@ pub async fn run() {
     // where errors could happen.
     // Note that the wallets created in this step are created "from scratch", i.e.
     // they are not created from known spend/view keys.
-    let expected_wallet_version = (1, 25);
+    let expected_wallet_version = (1, 22..26);
     helpers::wallet::get_version_assert_version(&wallet, expected_wallet_version).await;
 
     let (wallet_with_pwd, wallet_with_no_pwd, wallet_with_empty_pwd) = tokio::join!(

diff --git a/tests/clients_tests/helpers/regtest.rs b/tests/clients_tests/helpers/regtest.rs
@@ -230,8 +230,6 @@ fn test_get_block_header_assert_block_header(
         difficulty: u64,
         hash: BlockHash,
         height: u64,
-        major_version: u64,
-        minor_version: u64,
         nonce: u32,
         num_txes: u64,
         orphan_status: bool,

diff --git a/tests/clients_tests/helpers/wallet.rs b/tests/clients_tests/helpers/wallet.rs
@@ -1,4 +1,5 @@
 use std::collections::HashMap;
+use std::ops::Range;
 
 use monero::{
     cryptonote::subaddress::Index, util::address::PaymentId, Address, Amount, Hash, PrivateKey,
@@ -21,9 +22,13 @@ fn get_random_name() -> String {
         .collect()
 }
 
-pub async fn get_version_assert_version(wallet: &WalletClient, expected_version: (u16, u16)) {
+pub async fn get_version_assert_version(
+    wallet: &WalletClient,
+    expected_version: (u16, Range<u16>),
+) {
     let version = wallet.get_version().await.unwrap();
-    assert_eq!(version, expected_version);
+    assert_eq!(version.0, expected_version.0);
+    assert!(expected_version.1.contains(&version.1));
 }
 
 async fn create_wallet(

diff --git a/tests/clients_tests/non_empty_blockchain.rs b/tests/clients_tests/non_empty_blockchain.rs
@@ -66,6 +66,7 @@ pub async fn run() {
         difficulty: 1,
         hash: last_added_block_hash,
         height: regtest.get_block_count().await.unwrap().get() - 1,
+        // `*_version` are not tested inside the test functions below because they varies
         major_version: 16,
         minor_version: 16,
         nonce: 0,

diff --git a/tests/docker-compose.yml b/tests/docker-compose.yml
@@ -8,6 +8,7 @@ services:
       DIFFICULTY: 1
     ports:
       - 18081:18081
+
   monero-wallet-rpc:
     image: ghcr.io/farcaster-project/containers/monero-wallet-rpc:0.18.0.0
     environment: