Fix unconditional Return in obfs4 transport #130
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for unconditional return in obfs4 WrapConnection - move checks on proper data length earlier in the function and continue through loop when the MAC mark that we are looking for is not found.
closes #128
closes #133
Changes
obfs4
PhantomSelector
Proof that the fixes works:
TestSuccessfulWrapMulti - checks that a connection can be established for an obfs4 session even when multiple obfs4 sessions map to the same phantom address.
TestPhantomSeededSelectionFuzz - ensures no errors occur when subnets of all sizes (/0-/32) are used as the phantom subnet for selecting phantom addresses many times over (10,000 selections).
TestPhantomsSeededSelectionV4Min - ensures that minimal subnets work (i.e. /31, /32, /128, etc.)