Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode EOF in the api #15

Merged
merged 3 commits into from
May 20, 2020
Merged

Encode EOF in the api #15

merged 3 commits into from
May 20, 2020

Conversation

meditans
Copy link
Member

@meditans meditans commented May 1, 2020

This PR is meant as a solution for #7

@meditans meditans changed the base branch from develop to cn-#9-dont-block-network-when-child-blocks-stdin May 1, 2020 16:36
@meditans meditans requested a review from 3noch May 1, 2020 16:43
@meditans meditans marked this pull request as draft May 1, 2020 16:44
@3noch 3noch changed the base branch from cn-#9-dont-block-network-when-child-blocks-stdin to develop May 8, 2020 20:55
@3noch 3noch marked this pull request as ready for review May 8, 2020 20:55
@3noch 3noch merged commit b38205e into develop May 20, 2020
@3noch 3noch mentioned this pull request May 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3noch 3noch 3noch approved these changes

Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meditans @3noch