-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and test loading ORSO files #251
Conversation
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Can you describe what is broken, and then fixed by this PR? |
Will this work? What was broken:
What is fixed:
|
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
@bmaranville do we have a preferred docstring style for this project? I lean toward google/numpy style, but if what jose has added in this PR is ok with you, I'm good with it. |
I always favor Numpy style docstrings. They occupy a bit more lines but perhaps that's the reason I find them easier to read 😃 |
@bmaranville @glass-ships thanks for reviewing this |
What was broken:
load4
. Theimport
statement in webview's API was incorrect.What is fixed:
load4
in webview's APIparse_orso()
Check all that apply:
updated documentationAdded integration testsCheck list for the reviewer