Pytest plain asserts #244
Merged
Pytest plain asserts #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test work together again
glass-ships
approved these changes
Jan 3, 2025
|
I think based on the analysis of the ticket that was done in the scipy repo, that we can set up our pytest to be more targeted (it seems we're testing the entire codebase of scipy and all our other dependencies at the moment) - and if we do that we can probably turn assert rewriting back on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a conflict between the most recent scipy version (1.15) and the assertion-rewrite feature of pytest at the moment. Until this is resolved, we can use plain assertions (no rewrite) with pytest.
The only impact is that failed assertion messages might be slightly less informative.