-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting changes, update imports, other minor changes #227
Conversation
Fixed |
doc/pylit.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly don't know what this file is for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the only other place pylit gets used is in gentut.py
, but I dont think it references this file. safe to delete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't completely understand how the documentation gets created, tbh. Is there any chance sphinx makes stuff from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe sphinx references conf.py
which calls gentut.py
to generate the tutorials. but gentut.py
just imports pylit, which is just a direct copy of an old version of https://codeberg.org/milde/pylit/src/branch/master/pylit.py
We can either leave pylit.py as it is, or delete it and add pylit
to the pyproject.toml as a dev dependency.
I tested the latter option, and it seems to work just fine, so either option would be fine. Dealer's choice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good - a few minor changes suggested inline.
Sweet - comments have been addressed! |
This PR aims to include several auxiliary changes made in the Restructure PR #185, but without the restructure itself. Includes things like:
test_<test name>.py
along with some other small random changes.
Should be overall an unobtrusive set of changes.