Model setstate shim #216
Merged
Model setstate shim #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved from Stack Also remove custom __getstate__ from Repeat, and add shim to __setstate__ there as well
…alculation intact
acaruana2009
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a shim in
Stack.__setstate__to handle models that were pickled when there was a custom__getstate__on that class (prior to v1.0.0a6).The custom state object is a
tuple, which allows it to be easily distinguished from the default state object which is adict.Since the custom
__getstate__remains removed, models that are re-pickled (or dilled) after this will have the standarddictstate representation, that can be unpickled later after this shim__setstate__is removed.TODO: we can remove the
__setstate__completely at some point in the future.