Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client cdn #210

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Remove client cdn #210

merged 4 commits into from
Dec 9, 2024

Conversation

bmaranville
Copy link
Member

This PR implements a matching change to the one in bumps in this PR: bumps/bumps#172

The fallback CDN for refl1d-webview-client that had previously been published on npmjs, and mirrored with cdn.jsdelivr.net, would be removed from the webserver code.

It would then be required that client code exist at the path refl1d/webview/client/dist/.

  • Users installing from pip (pypi) will have this code included in the distributed package automatically
  • Developers running from an editable install will have to run python -m refl1d.webview.build_client every time the client source changes
    • they will also need to pull a new version of bumps in their editable install, prior to running the build_client command. It is not necessary to build the bumps client to build the refl1d client, just make sure the appropriate source files are in place in the bumps install.

Merging this PR will have to be synchronized with merging bumps/bumps#172

@bmaranville
Copy link
Member Author

Ok, this is a mess after I rebased it locally and pushed... I will clean up...

@bmaranville bmaranville merged commit 874abe5 into master Dec 9, 2024
6 of 12 checks passed
@glass-ships glass-ships deleted the remove-client-cdn branch December 9, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants