Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to using defaults for versioningit #209

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

bmaranville
Copy link
Member

The settings that are currently used for versioningit in the pyproject.toml specify that the "next" version should be used when doing a wheel build or local install.

This causes the unexpected behavior that if a developer makes a change to a repository file and then does a local install to test, it automatically versions the install with the next patch version, but this conflicts with the way we are incrementing our versions (local build will get e.g. version 1.0.1 before an actual release 1.0.1 is made with a new tag, which is how versioningit is supposed to increment the version.

The default behavior of versioningit is to create local versions based on the most recent tag, which is the correct thing to do here, I think. This PR removes our manual configuration of versioningit (which uses "next_version").

Copy link
Contributor

@mdoucet mdoucet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default formats use {base_version} rather than {next_version}, so that may be the main change that was needed.

@bmaranville bmaranville merged commit 6d65351 into master Oct 16, 2024
10 checks passed
@bmaranville bmaranville deleted the default-versioningit-settings branch October 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants