switch to using defaults for versioningit #209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settings that are currently used for
versioningit
in thepyproject.toml
specify that the "next" version should be used when doing a wheel build or local install.This causes the unexpected behavior that if a developer makes a change to a repository file and then does a local install to test, it automatically versions the install with the next patch version, but this conflicts with the way we are incrementing our versions (local build will get e.g. version 1.0.1 before an actual release 1.0.1 is made with a new tag, which is how
versioningit
is supposed to increment the version.The default behavior of
versioningit
is to create local versions based on the most recent tag, which is the correct thing to do here, I think. This PR removes our manual configuration ofversioningit
(which uses "next_version").