use separate rho_M_para and rho_M_perp profiles during contract_mag #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussed with @acaruana2009 and seems like a good idea to merge now. We noticed that in principle the divide-by-zero error should be a lot more common, as frequently we deal with models with The only reason it's not occuring is because the floating-point imprecision we typically operate at means that the above cosine calculation is not exactly zero, but about epsilon away from zero. |
bmaranville
added a commit
that referenced
this pull request
Apr 5, 2024
bmaranville
added a commit
that referenced
this pull request
Apr 5, 2024
bmaranville
added a commit
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would fix #172 I think.