Theta offset fix #116
Merged
Theta offset fix #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for PolarizedNeutronProbe
…ta_offset changes, or if theta_offset is not shared between cross-sections
…al calculation when a shared theta_offset changes
|
Tested, seems to show 10% slowdown in fits in worst case (single layer with microstepping disabled to emphasize model stepping overhead) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should address the Q-range for PolarizedNeutronProbe not matching the Q-range for the cross-sections in the Probe, when a non-zero theta_offset is present in one of the cross-sections (#114)
Uses a the cached self.calc_Qo if the theta_offset values in the cross-sections do not change.
If all the theta_offset values are the same, it does a minimal calculation to update Q (this is a common situation)
If all the theta_offset values are not all the same, and they change, a full calculation of the probe Q the (measurement_union(xs)) is called.