Fix branch dropdown position in clean-conversation-headers
#5598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheap-glitch
commented
Apr 16, 2022
Comment on lines
50
to
53
| /* Fixes vertical alignment of base branch dropdown */ | ||
| .rgh-clean-conversation-headers .commit-ref-dropdown { | ||
| margin-top: -2px !important; | ||
| } |
There was a problem hiding this comment.
This could technically be part of github-bugs.css since afaict it's not caused by this feature.
There was a problem hiding this comment.
The comment should have an issue number though
|
🤔 It works well for me in 22.4.1 Safari
Was it broken by the fix for #5585? |
It was likely broken by #5322, which was released in 22.4.11 |
fregante
approved these changes
Apr 21, 2022
clean-conversation-headersclean-conversation-headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the placement of the arrow icon, relative to the base branch dropdown that appears when editing the title of an open PR.
Test URLs
Screenshot
Before
After