Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create binary identical JARs for unmodified input #247

Closed
Bananeweizen opened this issue Mar 23, 2021 · 1 comment · Fixed by #257
Closed

create binary identical JARs for unmodified input #247

Bananeweizen opened this issue Mar 23, 2021 · 1 comment · Fixed by #257
Milestone

Comments

@Bananeweizen
Copy link
Contributor

The current 1.5.1 snapshot creates reproducible versions finally (due to the update of the maven-bundle-plugin dependency 4 weeks ago), if one configures the necessary settings as described here: https://maven.apache.org/guides/mini/guide-reproducible-builds.html.

That's great, now my p2 bundles are binary identical when running the build again, thereby not consuming another GB on artifactory after each build. However, JARs of transitive dependencies are still binary different, since they miss the same settings as described in the link above. Is there any way to influence the BND configuration for transitive dependencies except for making them explicit dependencies and configuring the same settings explicitly?

Would it eventually be possible to set these options internally for all calls of BND, no matter whether explicit artifact or transitive dependency artifact?

<_removeheaders>Bnd-LastModified</_removeheaders>
<_reproducible>true</_reproducible>
@sparsick
Copy link
Collaborator

@Bananeweizen Thanks for your hint. I will check it when I will start with issue #242 .

sparsick added a commit to sparsick/p2-maven-plugin that referenced this issue Apr 8, 2021
@sparsick sparsick added this to the 1.6.0 milestone Apr 8, 2021
sparsick added a commit that referenced this issue Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants