Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link with mailto:and https: #180

Closed
dornstein opened this issue May 29, 2015 · 3 comments
Closed

Add link with mailto:and https: #180

dornstein opened this issue May 29, 2015 · 3 comments
Labels

Comments

@dornstein
Copy link

Is there a reason the add link button is coded to only support http? You can't put in mailto: or https: links. This seems like a problem (and it for my users).

Seems like one line of (problematic) code:

       if (link !== null && link !== '' && link !== 'http://' && link.substr(0,4) === 'http') {

Am I missing something? Can this get improved?

@microcipcip
Copy link

I agree, it should also allow realtive links.

@toopay
Copy link
Member

toopay commented Jun 14, 2015

@dornstein PR? :)

@dornstein
Copy link
Author

Yeah, fair enough. For the moment I just had to pull out the third and fourth clauses in the check above, but I'll try to get you a PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants