chore(cli): remove most calls to commandDir
#9750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs more work; will re open this when it's actually closer to done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar vein to #9746, I was experimenting with bundling the CLI.
commandDirwas the first thing I ran into. We removed most of them in the past in an effort to speed up the CLI via "just in time" handler imports, but didn't remove them all since others were more difficult than others, and the gains were becoming less apparent.I've got most of them here in this PR save for
generateanddestroywhich use helpers that are nontrivial to refactor. While the files touched and diffs are large, this PR was mostly just a chore, moving code into different files.I'm marking this as breaking because I'm removing two deploy providers that we no longer support, edgio and serverless.