Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): Disable telemetry during framework cli unit tests #7876

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

Problem
We are now observing the creation of telemetry related files after running the framework cli tests. This indicates that telemetry has been triggered during these tests which is unwanted behaviour.

Solution
Set the REDWOOD_DISABLE_TELEMETRY env var before the cli tests are started.

@Josh-Walker-GM Josh-Walker-GM added the release:chore This PR is a chore (means nothing for users) label Mar 20, 2023
@replay-io
Copy link

replay-io bot commented Mar 20, 2023

16 replays were recorded for 1cf0bf7.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/8c2df847-1729-45d9-8b6f-7d023d4b9b4d>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/d9461b13-3c0d-4808-9563-4768969d3f12>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/5b773284-0836-46b8-922b-4f3cb3e3d361>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/e0a293c4-8166-4abf-a2b4-45b5cf6313a0>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/20570a15-eee6-4bbc-a263-1026ed627f69>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/1681bd3b-e8f8-423c-9e4f-7c39579df84f>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/2f6f69c1-4956-4617-ad49-f3b8f720e863>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/c803d6bd-b882-417a-bb4f-3d17d248fc32>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/411ed8c7-e003-499e-a57d-66776a6bdfdc>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/eabd16c7-65ff-4639-be67-6eb3a36f55ea>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/53639035-ad0b-4e17-a7b0-bdd8048c5be2>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/55b2246a-e38b-40bc-9b0f-bd2adb54b3f1>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/72fb449d-3a3b-4a34-8fba-716364e324d2>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/d93f1b50-e4cc-41ea-9840-21d53d5add7e>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/34fc6b77-54d0-4d83-87e9-c42aa0eb0fd2>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@Josh-Walker-GM Josh-Walker-GM changed the title chore(cli): Disable telemetry during framework cli tests chore(cli): Disable telemetry during framework cli unit tests Mar 20, 2023
@Josh-Walker-GM Josh-Walker-GM marked this pull request as ready for review March 20, 2023 22:10
@Josh-Walker-GM
Copy link
Collaborator Author

@dac09 As we found and discussed a while back now.

@Josh-Walker-GM Josh-Walker-GM requested a review from dac09 March 20, 2023 22:11
@dac09
Copy link
Contributor

dac09 commented Mar 21, 2023

I think there's still one missing piece where the disabled version calls the function differently, but I'll cover it in this PR here: #7672 - when I pick it up again!

@dac09 dac09 enabled auto-merge (squash) March 21, 2023 05:19
@dac09 dac09 merged commit 574f157 into main Mar 21, 2023
@dac09 dac09 deleted the jgmw-cli-no-telemetry-in-tests branch March 21, 2023 05:46
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Mar 21, 2023
jtoar pushed a commit that referenced this pull request Mar 23, 2023
Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
@thedavidprice thedavidprice modified the milestones: next-release, v4.4.0 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants