-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Convert custom webpack cell-loader into Babel Plugin #512
[Core] Convert custom webpack cell-loader into Babel Plugin #512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think this is perfect, but I also don't have a bunch of experience with ASTs. @mojombo did the last implementations for our eslint, router, and cell plugins.
I've made a few suggestions for comments and variable names that reduce the abstractness for the reader of this code.
Added some documentation and improved readability Co-authored-by: Peter Pistorius <peter.pistorius@gmail.com>
@peterp Thanks for the feedback! It's processed. 👍 I've decided to name the variable what it is; I also added some tests for the plugin. I noticed tests weren't running on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing work, thank you so much Robert!
@RobertBroersma great work all around here, Robert, from super helpful inline comments to ramping up tests for the core package! 🚀 |
This implements #503 and opens up the possibility for using Cells in Jest!
I've never written a Babel Plugin or done anything with AST's before, so I just wanted to get this out here to gather some feedback before looking into writing tests for it, and also to discuss on where to locate the plugin file!
This also fixes some issues with Cells where they break if you comment out some const exports and supports using function declarations instead of variable function declarations!