Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Add SelectField #364

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Conversation

RobertBroersma
Copy link
Contributor

Not sure if it should be called SelectField or just Select.

@thedavidprice
Copy link
Contributor

Our CI Checks were not running for PRs from external, forked repos. See #358

This is now fixed but will not retroactively apply to this PR. Before merging, please locally confirm the following checks pass:

  • yarn build
  • yarn lint
  • yarn test

Thanks in advance!

@RobertBroersma
Copy link
Contributor Author

Hey @thedavidprice

I did run those locally, but merged your fixes into my branch just in case!

Copy link
Member

@cannikin cannikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks!

@cannikin cannikin merged commit 97a7c30 into redwoodjs:master Apr 1, 2020
mohsen1 pushed a commit to mohsen1/redwood that referenced this pull request Apr 12, 2020
@thedavidprice thedavidprice added this to the unassigned-version milestone May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants