Use URLSearchParams for parsing search params

[mohsen1]

URL search params is a lot more involved than simple split by & and making a a key/value pair from it. I noticed in the router an assumption is made that search params are not repeated. This PR does not fix the issue because this assumption goes deeper in the router. Instead, I've introduced standard URLSearchParasm for parsing the search params which handles a lot of corner cases such as unicode and also allow us to get a list for repeated search arguments if we decided to support that.

I've also updated comments in the util.js to use JSDoc so comments show up in hover in editors.

Also used String.prototype.startsWith instead of path[0] for better readability.

---

P.S. This is my first PR and you should expect a lot more contribution from me to come! I love how this project is set up and the decisions that are made are almost perfect! ❤️

[mohsen1]

Here it is possible to do searchParams.getAll(key) instead

[mojombo]

Great suggestion! I wonder if there's a way to have Babel dictate the inclusion of the polyfill instead of including it directly. We'd like to end up allowing users to specify what browser support they want to satisfy and have all Redwood dependencies be transpiled for that specification, at which point Babel could make the decision of whether this polyfill was needed or not.

@peterp curious what our latest thinking is on this.

[mohsen1]

So according to Babel docs for preset-env we can enable useBuiltIns and set it to "usage", then core-js will be pollyfilling things like URLSearchParams according to the browserlist config.

Going to try this out and let you know how it works in practice.

[mohsen1]

Ok, if Redwood is compiling router in userland using Babel, it will add the polyfill as it does in compiled version here:

"use strict";

var _interopRequireDefault = require("@babel/runtime-corejs3/helpers/interopRequireDefault");

var _Object$defineProperty = require("@babel/runtime-corejs3/core-js/object/define-property");

_Object$defineProperty(exports, "__esModule", {
  value: true
});

exports.replaceParams = exports.validatePath = exports.parseSearch = exports.matchPath = exports.createNamedContext = void 0;

var _concat = _interopRequireDefault(require("@babel/runtime-corejs3/core-js/instance/concat"));

var _keys = _interopRequireDefault(require("@babel/runtime-corejs3/core-js/object/keys"));

var _forEach = _interopRequireDefault(require("@babel/runtime-corejs3/core-js/instance/for-each"));

var _getIterator2 = _interopRequireDefault(require("@babel/runtime-corejs3/core-js/get-iterator"));

var _startsWith = _interopRequireDefault(require("@babel/runtime-corejs3/core-js/instance/starts-with"));

var _keys2 = _interopRequireDefault(require("@babel/runtime-corejs3/core-js/instance/keys"));

var _urlSearchParams = _interopRequireDefault(require("@babel/runtime-corejs3/core-js/url-search-params"));

var _defineProperty2 = _interopRequireDefault(require("@babel/runtime-corejs3/helpers/defineProperty"));

var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime-corejs3/helpers/slicedToArray"));

var _slice = _interopRequireDefault(require("@babel/runtime-corejs3/core-js/instance/slice"));

[thedavidprice]

Our CI Checks were not running for PRs from external, forked repos. See #358

[EDIT: master merged into PR, which trigger checks. Thanks!]

Thanks in advance!

[peterp]

This looks good to me, I just need to test it locally, and write a test to make sure. :)