Allow creating app in existing empty dir #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried `yarn create redwood-app .` in an empty directory where I wanted the files generated, and got an error saying the dir already exists. I think it should be OK to use an existing directory if it's empty 🙂 I have also moved the error out of the Listr task itself, because it seems Listr is not actually stopping execution of the following tasks. At least, it continues outputting the next tasks' titles, which is confusing: I'd say an early exit for this particular error is acceptable?
|
This doesn't disturb the flow of a developer, so it's a useful feature to have. Thanks, @olance! |
peterp
requested changes
Mar 22, 2020
| const appDirExists = fs.existsSync(newAppDir) | ||
|
|
||
| if (appDirExists && fs.readdirSync(newAppDir).length > 0) { | ||
| throw new Error(`'${newAppDir}' already exists and is not empty.`) |
There was a problem hiding this comment.
This would result in an uncaught exception, it would be better to use a combination of console.log and process.exit(1)
|
@peterp thanks, I’ll do that tomorrow 🙂 |
peterp
approved these changes
Mar 24, 2020
mohsen1
pushed a commit
to mohsen1/redwood
that referenced
this pull request
Apr 12, 2020
Allow creating app in existing empty dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried
yarn create redwood-app .in an empty directory where I wanted the files generated, and got an error saying the dir already exists.I think it should be OK to use an existing directory if it's empty 🙂
I have also moved the error out of the Listr task itself, because it seems Listr is not actually stopping execution of the following tasks. At least, it continues outputting the next tasks' titles, which is confusing:
I'd say an early exit for this particular error is acceptable?