Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache magic.link's token #2555

Merged
merged 8 commits into from
May 22, 2021
Merged

Cache magic.link's token #2555

merged 8 commits into from
May 22, 2021

Conversation

simoncrypta
Copy link
Collaborator

This cache magic.link's token for 10min
fix #2501

Copy link
Contributor

@peterp peterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Just a small suggestion to remove the extra check.

@peterp
Copy link
Contributor

peterp commented May 19, 2021

@burnsy Thought you would be interested in seeing the solution for this

Simon Gagnon and others added 4 commits May 19, 2021 16:28
Co-authored-by: Peter Pistorius <peter.pistorius@gmail.com>
Co-authored-by: Peter Pistorius <peter.pistorius@gmail.com>
@simoncrypta simoncrypta requested a review from peterp May 19, 2021 20:36
@jtoar jtoar added this to the next-release-candidate milestone May 19, 2021
@BurnedChris
Copy link
Contributor

This looks great will try it in my own app soon 👍🏻

@BurnedChris
Copy link
Contributor

@simoncrypta just tried this in my own app and the code works great! LGTM @peterp

@peterp peterp merged commit f048fc1 into redwoodjs:main May 22, 2021
dac09 added a commit to dac09/redwood that referenced this pull request May 24, 2021
…-codegen

* 'main' of github.com:redwoodjs/redwood:
  Removes console warnings in webhook verifiers (redwoodjs#2563)
  build(deps): bump eslint from 7.26.0 to 7.27.0 (redwoodjs#2610)
  CONTRIBUTING.md: styling tweaks for improved readability and consistency (redwoodjs#2608)
  build(deps): bump esbuild from 0.11.21 to 0.12.1 (redwoodjs#2579)
  Cache magic.link's token  (redwoodjs#2555)
  build(deps): bump @babel/plugin-transform-runtime from 7.14.2 to 7.14.3 (redwoodjs#2603)
  build(deps): bump @types/node from 15.3.1 to 15.6.0 (redwoodjs#2601)
  eslint-plugin-import 2.23.2 with lint fixes (redwoodjs#2604)
  build(deps): bump @apollo/client from 3.3.18 to 3.3.19 (redwoodjs#2576)
  build(deps): bump apollo-server-lambda from 2.22.2 to 2.24.1 (redwoodjs#2580)
  build(deps): bump babel-plugin-graphql-tag from 3.2.0 to 3.3.0 (redwoodjs#2600)
  build(deps): bump @babel/cli from 7.13.16 to 7.14.3 (redwoodjs#2578)
  build(deps-dev): bump @types/lodash from 4.14.169 to 4.14.170 (redwoodjs#2597)
  build(deps-dev): bump @types/findup-sync from 2.0.2 to 4.0.0 (redwoodjs#2574)
  Aggregate Dependabot misc patch minor upgrades (redwoodjs#2596)
  CONTRIBUTING.md: add missing char (redwoodjs#2594)
  changes test command instructions to reference run-e2e instead of test-tutorial (redwoodjs#2593)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache magic.link's token
5 participants