Use host configuration provided in redwood configuration file (so that VM/container users can set it to "0.0.0.0")

[suvash]

Instead of hardcoding/assuming development host to be localhost,
make it configurable so that redwood servers being run inside a
container/VM can still be accessed setting host to "0.0.0.0"

The accompanying PR for create-redwood-app is at : redwoodjs/create-redwood-app#32

[peterp]

Thanks for this, could you add this to the types over here:

redwood/packages/internal/src/types.ts

Lines 1 to 12 in fa396e0

	export type Config = {
	web: {
	port: number
	apiProxyPath: string
	}
	api: {
	port: number
	}
	browser: {
	open: boolean | string
	}
	}

It would be great if we didn't have to specify this in redwood.toml and provided defaults of localhost to the webpack/ dev-server

[suvash]

sure thing.

[suvash]

I've gone for the minimum code changes possible here. (instead of defining intermediate vars etc.) I don't have a way to test it now, but can do it tomorrow. Let me know if you had something else in mind.

[peterp]

This is awesome, thank you @suvash !

[thedavidprice]

@suvash @peterp Quick glance at this —> looks like the doc could use some updating+tlc with info about this change, correct?

https://github.com/redwoodjs/redwood/blob/master/docs/redwood.toml.md

If so, possible to get some help? And/or open a new issue and assign it to me fine as well.

[suvash]

@thedavidprice @peterp Updated the docs at #228

[ryancwalsh]

@suvash Thanks for your PR. If you have a moment, I wonder if you easily see what I'm doing wrong when trying to run RedwoodJS yarn rw dev while using a Vagrant VM: #475 Thanks!

[suvash]

I don't have a vagrant/virtualbox setup right now, and I see you have it resolved, so I won't dig into this further. 👍

[ryancwalsh]

@suvash Yep, thanks!