Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ @redwood/web typing: Add types to createGraphQLClient and GraphQLProvider #1241

Merged
merged 16 commits into from
Sep 30, 2020
Merged

✨ @redwood/web typing: Add types to createGraphQLClient and GraphQLProvider #1241

merged 16 commits into from
Sep 30, 2020

Conversation

kimadeline
Copy link
Contributor

@kimadeline kimadeline commented Sep 29, 2020 •
edited
Loading

References #1217

Add types to:

  • createGraphQLClient
  • GraphQLProvider

💔 I'm splitting the typing of withCell to a separate PR (it currently lives in https://github.com/kimadeline/redwood/tree/1217-withcell).

@kimadeline kimadeline changed the title @redwood/web typing: Add types to packages/web/src/graphql @redwood/web typing: Add types to createGraphQLClient and GraphQLProvider Sep 29, 2020
@kimadeline kimadeline marked this pull request as ready for review September 29, 2020 21:12
@kimadeline kimadeline requested a review from peterp September 29, 2020 21:13
@kimadeline kimadeline changed the title @redwood/web typing: Add types to createGraphQLClient and GraphQLProvider ✨ @redwood/web typing: Add types to createGraphQLClient and GraphQLProvider Sep 29, 2020
peterp
peterp approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@peterp peterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@peterp peterp added this to the Next release milestone Sep 30, 2020
@peterp peterp merged commit da73314 into redwoodjs:main Sep 30, 2020
@kimadeline kimadeline deleted the 1217-graphql-provider branch September 30, 2020 14:54
@thedavidprice thedavidprice removed this from the Next release milestone Oct 15, 2020
@thedavidprice thedavidprice added this to the added to release notes milestone Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterp peterp peterp approved these changes

Assignees
No one assigned
Labels
topic/web
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kimadeline @peterp @thedavidprice