Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Redux logo as favicon on GitBook docs #1761

Merged
merged 1 commit into from
May 23, 2016
Merged

Conversation

jtmthf
Copy link
Contributor

@jtmthf jtmthf commented May 23, 2016

Added favicon and apple-touch-icon to docs as requested in #1735.

I added the files to the logos directory as that seemed the most logical place to put them. Upon the docs:build step, the image files are copied into the built GitBook.

@gaearon gaearon merged commit 3c900de into reduxjs:master May 23, 2016
@gaearon
Copy link
Contributor

gaearon commented May 23, 2016

Thanks! I couldn’t find a way to bust the cache and change the URL to something like favicon.ico?v2 so it’ll only be visible to those who haven’t visited the docs yet.

@jtmthf
Copy link
Contributor Author

jtmthf commented May 23, 2016

Another more flexible option would be to fork the default theme. As of GitBook 3.0 that's now an option that can be specified in the book.json. The documentation is sparse, but I think I could figure it out. Only consequence is that the theme would be behind on commits from the upstream theme.

@gaearon
Copy link
Contributor

gaearon commented May 23, 2016

I don’t think it’s worth it, tbh. Let’s keep it simple!

seantcoyote pushed a commit to seantcoyote/redux that referenced this pull request Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants