Add todos example tests #1471
Add todos example tests #1471
Conversation
|
@gaearon wanted to get this opened up for initial review. Originally @urbanvikingr and I were going to pair on these, but my son was born a tad early so I wasn't able to stick to a schedule so we decided to split them. I last heard from @urbanvikingr that he was dealing with some issues and didn't have a lot of spare time about a week ago, so I didn't want this to appear forgotten about. I completed tests for each component, but wanted to leave the option open for @urbanvikingr to contribute some additional test cases, or tests around the container elements if he finds the time. |
|
@jontewks Thank you. I suggest that we merge your additional tests. Then, the |
|
Hi Guys, How these tests are better than the ones in #1463? Have you looked? is it more reasonable to make app easier to test first? Cheers, Cheng |
|
This looks like a good start to me, please continue! |
|
Hey @jontewks! We started porting tests to Enzyme (#1481), and @mjw56 submitted a PR handling Can you please review #1493 and leave your thoughts on it? Is there anything from here that is missing there? |
|
Thanks @gaearon, and no worries. Sorry this happened so slowly, my wife and I just had a child a tad early so I didn't have nearly the amount of time to put into this as I was hoping. The new tests look good, and I learned from reading through them, like expect has a Things have calmed down for us now, so if there is anything else that I can contribute to, I have the spare time this week. Thanks again. |
|
I apologize, I should have gone through the open PR's first before working on this. I'll make sure this does not happen again. Thanks for the feedback @jontewks. I also just reviewed yours as well to make sure we are all on the same page. Again, sorry for the mixup. Congrats on your new child! 😃 |
Per issue #1397