Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable search for react-redux site #1060

Merged
merged 1 commit into from
Oct 24, 2018
Merged

chore: enable search for react-redux site #1060

merged 1 commit into from
Oct 24, 2018

Conversation

endiliey
Copy link
Contributor

Motivation

Docusaurus maintainer here. Happy to see react-redux using Docusaurus for it's documentation site. Thanks to whoever started doing it.

Summary

This PR enable search for https://react-redux.js.org/ documentation

Test Plan

redux

@netlify
Copy link

netlify bot commented Oct 24, 2018

Deploy preview for react-redux-docs ready!

Built with commit f0a2ecf

https://deploy-preview-1060--react-redux-docs.netlify.com

@endiliey endiliey changed the title docs: enable search for docusaurus site chore: enable search for react-redux site Oct 24, 2018
@timdorr
Copy link
Member

timdorr commented Oct 24, 2018

Whose API key is that? We have an account for the previous GitBook-based site, so we can end up using that.

@endiliey
Copy link
Contributor Author

Its a new api key i just applied from algolia that index the new redux site. There is no account associated with it because it is a docSearch api key.

I believe the old one wont work because there is no docsearch config associated.

In simple word, it works much much simpler way in Docusaurus

@Haroenv
Copy link

Haroenv commented Oct 24, 2018

@s-pace can help you all get access to the analytics on the docsearch

@s-pace
Copy link

s-pace commented Oct 24, 2018

Sure thing.

@timdorr Please send us an email to docsearch@algolia.com from the email address of your algolia account (if you have already one) or from a new email address (we will provide you a link to create your account). We will grant you access to the analytics of this react-redux DocSearch index

@timdorr
Copy link
Member

timdorr commented Oct 24, 2018

Cool, just sent in that email. Thanks for the PR, @endiliey!

@timdorr timdorr merged commit bc7b6a9 into reduxjs:master Oct 24, 2018
@endiliey endiliey deleted the search branch October 24, 2018 15:01
albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants