[v2.1] Flicker Improvement Update #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
redthirten
commented
Jul 11, 2024
- Changed flicker pattern from random to sawtooth to better emulate a fluorescent bulb.
- Randomized flicker phase between different SCOs so they don't all flash in unison (which was unpleasant if the lights were all in the same room/area).
- Changed "Flicker Time" parameter to "Max Flicker Time".
- Randomized total flicker time between different SCOs (within the configured max flicker time), which better emulates the randomness of real fluorescent bulbs turning on.
- Refactored some code.
- Updated the demo park.
- Changed flicker pattern from random to sawtooth to better emulate a fluorescent bulb. - Randomized flicker phase between different SCOs so they don't all flash in unison (which was unpleasant if the lights were all in the same room/area). - Changed "Flicker Time" parameter to "Max Flicker Time". - Randomized total flicker time between different SCOs (within the configured max flicker time), which better emulates the randomness of real fluorescent bulbs turning on. - Refactored some code. - Updated the demo park.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.