Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assetalloc_class fail due to favapricemap vs beancount pricemap #92

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix: assetalloc_class fail due to favapricemap vs beancount pricemap #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions fava_investor/modules/assetalloc_class/libassetalloc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ def ancestors(s):


def bucketize(vbalance, accapi):
price_map = accapi.build_price_map()
f_price_map = accapi.build_price_map()
b_price_map = accapi.build_beancount_price_map()
commodities = accapi.get_commodity_directives()
operating_currencies = accapi.get_operating_currencies()
base_currency = operating_currencies[0]
Expand All @@ -101,13 +102,13 @@ def bucketize(vbalance, accapi):

# what we want is the conversion to be done on the end date, or on a date
# closest to it, either earlier or later. convert_position does this via bisect
amount = accapi.convert_position(pos, base_currency, price_map, date=end_date)
amount = accapi.convert_position(pos, base_currency, f_price_map, date=end_date)
if amount.currency == pos.units.currency and amount.currency != base_currency:
# Ideally, we would automatically figure out the currency to hop via, based on the cost
# currency of the position. However, with vbalance, cost currency info is not
# available. Hence, we hop via any available operating currency specified by the user.
# This is for supporting multi-currency portfolios
amount = convert.convert_amount(pos.units, base_currency, price_map,
amount = convert.convert_amount(pos.units, base_currency, b_price_map,
via=operating_currencies, date=end_date)
if amount.currency != base_currency:
sys.stderr.write("Error: unable to convert {} to base currency {}"
Expand Down
Loading