Draft: Implement timeout in amqp_0_9 output #1342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A solution to use context is merged in rabbitmq/amqp091-go#96 so we can manage timeout of confirmation now in benthos.
I based myself on benthos aws s3 timeout configuration as an example and set default to unlimited wait (previous logic).
This is not yet heavily tested but I opened the MR since I think it is near finish so if you have any change needed don't hesitate to send them already.
Fix #1299