-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to disable local caching #79
Comments
Sure, a separate flag to disable the cache is much easier to implement. |
Hi @GiedriusS, v0.0.71 now has a In terms of the second thing, |
I see. I am reading the code a bit now. So, it doesn't matter what |
Hi @GiedriusS, The time.Duration you passed will take effect in two cases:
|
I see, it makes sense! Thank you for the response. I'll continue on with thanos-io/thanos#5593. |
Currently, "cache size each conn" is set to the default value if
0
is provided: https://github.com/rueian/rueidis/blob/master/rueidis.go#L201-L203, https://github.com/rueian/rueidis/blob/8b21fc0a8614397bbe4beada7292f2b9431a9d18/pipe.go#L63. Perhaps we could skip theLRU
entirely if zero has been passed? However, that would be a breaking change. Perhaps a separate flag could exist such asDisableLocalCache
?Ran into this while doing thanos-io/thanos#5593. I think some users might not want to cache items locally if their systems don't have much RAM, for example.
The text was updated successfully, but these errors were encountered: