Refactor pubusb to allow subscribing and unsubscribing from another thread #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8abde03 to
73dc8e2
Compare
…hread redis-rb pubsub always has been very hard to work with, because once you are subscribed, you can no longer manage the subscription outside of the various callback. But the `SUBSCRIBE` family of command returns no response, and the subscribed client only reads the socket. So we can actually send `SUBSCRIBE` style of commands from another thread.
73dc8e2 to
3df7192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redis-rb's pubsub always has been very hard to work with, because once youare subscribed, you can no longer manage the subscription outside of
the various callback.
But the
SUBSCRIBEfamily of command returns no response, and thesubscribed client only reads the socket. So we can actually send
SUBSCRIBEstyle of commands from another thread.