Fixed unsecured tempfile.mktemp() command usage #3446
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladvildanov
added a commit
that referenced
this pull request
Dec 6, 2024
* Migrate to clients test image (#3415) * Migrate to client-testing image - Use clients-testing image for standalone and cluster - Remove hardcoded TLS certificates and keys - Remove stunnel - Remove Cluster docker and configs * Fix migration bugs * Create reusable action to run tests - Reduce copy paste by using reusable action for running tests - Gain better control of tests matrix Add missing actions checkout More fixes in integration workflow Another attempt to fix matrix * Reorg test matrix * Fix jobs names and execution order * Execute standalone and cluster test simultaneously * Streamline test execution - Automatically map Redis version to Redis Stack version and use it for testing module commands - Remove Graph commands from execution by default - Include more Redis versions to the test matrix * More fixes to integration job * Move python compatibility tests to a separate task * Improve run-tests action * Add missing pytest marks for TS tests * Fix cluster configuration * Debug cluster tests * Fix Cluster TLS port * Move current redis version to env var * Fix ssl tests * Show CLUSTER NODES on fail * Fix integration workflow bugs * Add workarounds for IPv6 bug in tests * Use hostname instead of hardcoded IPv4 loopback * Fix bug in _get_client * Fix run-tests action * Fix imports * Add missing version guards in search tests * Add compatibility for Redis < 7 * Add missing version guard in search tests * Fix run-tests * Add missing tls-auth-clients option * Skip module tests when Redis < 7 and RESP3 is enabled * Fix async test_moved_redirection_on_slave_with_default The test was broken for a while after migrating to all-in-one container with Cluster * Cleanup test after debugging * Use correct profile in install_and_test.sh * Use matrix to execute hiredis<=3.0.0 tests * Fix hiredis job * Fix pytest command in install_and_test.sh * Use 7.4.1 as default version in docker-compose.yml * Fix uvloop-tests * Fixed unsecured tempfile.mktemp() command usage (#3446) * Fixed unsecured tempfile.mktemp() command usage * Added proper tuple handling * Fixed bug with SLOWLOG GET response parsing from Redis Enterprise (#3441) * Fixed issue with invoking _close() on closed event loop (#3438) * Fixed issue with invoking _close() on closed event loop * Removed unused import * Revert weakref changes * Codestyle fix * Added test coverage * Codestyle fixes * Codestyle fixes * Removed failure check that fails in 3.12 * Codestyle fixes * Codestyle fixes * Fixing randomly failing test (#3437) * Fixing randomly failing test * Always rounding up to avoid randomly failing tests * Always rounding up to avoid randomly failing tests --------- Co-authored-by: Vladyslav Vildanov <117659936+vladvildanov@users.noreply.github.com> * Updated package version --------- Co-authored-by: Igor Malinovskiy <u.glide@gmail.com> Co-authored-by: Ilian Iliev <ilian@ilian.io>
akx
reviewed
Dec 7, 2024
Comment on lines
1521
to
+1525
|
|
||
| root = tempfile.mkdtemp() | ||
| sub = tempfile.mkdtemp(dir=root) | ||
| jsonfile = tempfile.mktemp(suffix=".json", dir=sub) | ||
| nojsonfile = tempfile.mktemp(dir=root) | ||
| jsonfile = tempfile.mkstemp(suffix=".json", dir=sub)[1] | ||
| nojsonfile = tempfile.mkstemp(dir=root)[1] |
There was a problem hiding this comment.
This should honestly just use the tmp_path fixture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.