Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname field to _parse_node_line #3343

Merged

Conversation

dudizimber
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

fix #3342

Added the hostname field to the return of the CLUSTER NODES command.

@gkorland gkorland requested a review from dvora-h September 2, 2024 08:13
@gkorland
Copy link
Collaborator

gkorland commented Sep 2, 2024

@vladvildanov

@vladvildanov vladvildanov merged commit 147f7ca into redis:master Sep 2, 2024
56 checks passed
@vladvildanov vladvildanov added the breakingchange API or Breaking Change label Sep 3, 2024
@vladvildanov vladvildanov removed the breakingchange API or Breaking Change label Sep 27, 2024
vladvildanov added a commit that referenced this pull request Sep 27, 2024
Co-authored-by: Vladyslav Vildanov <117659936+vladvildanov@users.noreply.github.com>
vladvildanov added a commit that referenced this pull request Sep 27, 2024
Co-authored-by: Vladyslav Vildanov <117659936+vladvildanov@users.noreply.github.com>
vladvildanov added a commit that referenced this pull request Sep 27, 2024
Co-authored-by: Vladyslav Vildanov <117659936+vladvildanov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLUSTER NODES command does not return the node hostname
3 participants