-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for KNN vector similarity search #513
Conversation
@chayim where should I add instructions for using this feature? |
IMHO we should start a separate vectorsimilarity doc... @elena-kolevska given what you're up to - any preference? |
Looping in @bsbodden, who's starting to work on a VSS quickstart for redis.io. |
bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type hint asks mostly
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
- Coverage 78.94% 78.13% -0.82%
==========================================
Files 14 14
Lines 1178 1267 +89
==========================================
+ Hits 930 990 +60
- Misses 248 277 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Okay, it's been more than a month. And this hasn't been merged even though all that's being corrected are type hints. |
Hi folks. I just merged in #534 so that we can have a CI that is properly reflective and runs this, and tests. That was the first step. Logic wise, this looks proper, and as if it fits with the rest of this library. Merging in the master changes, and giving it another look. I'm pro merging this - and issuing a release. |
Added components
KNNExpression
, to be passed toRedisModel.find()
. Can be used in conjunction with normal operators, e.g.:VectorFieldOptions
, a simpledataclass
to encapsulate the settings for a vector field; passed toField(vector_options=
.Changed components
JsonModel
andHashModel
, to accommodate vector fieldsRedisModel.from_redis()
, to add a field containing the vector score when applicableFindQuery
, to incorporate KNN vector search support